Open
Conversation
useful not usefull 😜
Fix error emitter for search
Completed start/stop on base sonos class
…wait for initial data
Logical Device Support
…ll device initializations have completed.
Fixed async usage to only invoke LogicalDevice.search callback when a…
Save groupId per LogicalDevice
|
I'm just getting familiar with airsonos and node-sonos, and getting familiar with all the branches, so I might be off base, but here goes nothing: Should this PR be against stephen:stephen-1.0.0 instead of stephen:master? stephen:stephen-1.0.0 is the branch that's used by airsonos, and I think it's the branch that is, at some point, is going to be merged with bencevens node-sonos project, which I'm assuming is the canonical version of node-sonos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the crash when starting airsonos