Conversation
kylef
reviewed
Jan 22, 2018
Collaborator
There was a problem hiding this comment.
Started reviewing, but then thought about #189 (comment), submitting comment review for posterity. But perhaps these two filters can be combined.
|
|
||
| func valueForKeyFilter(value: Any?, arguments: [Any?], context: Context) throws -> Any? { | ||
| guard arguments.count == 1 else { | ||
| throw TemplateSyntaxError("'split' filter takes a single argument") |
Collaborator
There was a problem hiding this comment.
Looks like copy/paste error with filter name (split -> valueForKey)
| let result = try template.render(Context(dictionary: ["key": "name", "value": ["name": "One"]])) | ||
| try expect(result) == "One" | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I think it might be a good idea to include a more complex example which validates that the filter uses the logic for variable lookup (perhaps in future some refactoring could break this currently supported behaviour):
let context: [String: Any] = [
"user": ["name": "Kyle"]
]
let template = Template(templateString: "{{ value|valueForKey:"user.name" }}")|
|
||
| let key = stringify(arguments[0]) | ||
| return try context.push(dictionary: ["filter_value": value as Any]) { | ||
| return try Variable("filter_value.\(key)").resolve(context) |
Collaborator
There was a problem hiding this comment.
I think it would make sense that this could handle arrays, similar to NSArray valueForKey:.
This would allow chaining valueForKey with join.
{{ users|valueForKey:"name"|join }}
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the same functionality as #174 but with less confusing API.