Correct the types file. #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving it as `index.d.ts` causes stencil.core.d.ts not being generated with a fresh `stencil build` (run `stencil build` again will generate stencil.core.d.ts file though), because it's checking if index.d.ts file exists, but it really should be checking if components.d.ts file exists.
|
Will fix #81 |
Author
|
Friendly ping to see if this one needs more changes. Thanks! |
|
My experience is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving it as
index.d.tscauses stencil.core.d.ts not being generated with a freshstencil build(runstencil buildagain will generate stencil.core.d.ts file though), because it's checking if index.d.ts file exists, but it really should be checking if components.d.ts file exists.