MSVS project updates #5097
Open
MSVS project updates #5097
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the MSVS (Visual Studio) project configuration to enable better lambda support and includes previously missing files. The changes modernize the compiler settings and clean up unnecessary forward declarations.
Changes:
- Enable
/Zc:lambdacompiler flag for modern lambda parsing across all build configurations - Add missing
LedgerEntryScope.cppandLedgerEntryScope.hfiles to the Visual Studio project - Update lambda code to work with the new compiler flag by removing unused capture
- Remove unnecessary friend declaration from
LedgerEntryScope.h
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Builds/VisualStudio/stellar-core.vcxproj | Adds /Zc:lambda flag to all build configurations and includes missing LedgerEntryScope files |
| Builds/VisualStudio/stellar-core.vcxproj.filters | Adds missing LedgerEntryScope files to the ledger filter group |
| src/simulation/test/LoadGeneratorTests.cpp | Removes unused frameSize capture from lambda to comply with /Zc:lambda |
| src/ledger/LedgerEntryScope.h | Removes unnecessary friend declaration for stream operator |
| src/rust/soroban/p25 | Updates subproject commit reference |
| src/protocol-curr/xdr | Updates subproject commit reference |
- Enable `Zc:lambda` for a more modern lambda parser (also update the respective code that prompted enabling this) - Add the missing files to the project - Remove an unnecessary friend declaration that has confused MSVC compiler and doesn't seem necessary for anything
graydon
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Zc:lambdafor a more modern lambda parser (also update the respective code that prompted enabling this)Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)