Publish command #1826
Publish command #1826
Conversation
|
This needs to be rebased @vogel |
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
|
Rebased |
src/main/ApplicationUtils.cpp
Outdated
|
|
||
| // set known cursors before starting maintenance job | ||
| ExternalQueue ps(*app); | ||
| ps.setInitialCursors(app->getConfig().KNOWN_CURSORS); |
There was a problem hiding this comment.
it would be cleaner to just set the right config elements so that app->start() does what you want (in this case, I think you just need to set STANDALONE to true)
There was a problem hiding this comment.
STANDALONE is set before - in CommandLine.cpp:runPublish function, by calling to Config::setNoListen.
Maintenance job is normally started in ApplicationImpl::start, which we don't use in command-line catchup and publish. I think we could move calling maintenance to the end of catchup/publish process, or just ignore that and postpone the maintenance itself to normal stellar-core runs (but we can't be sure there will be no instances of stellar-core used only for command-line catchup and publish).
There was a problem hiding this comment.
You didn't understand my question: why not calling start if standalone is already set?
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
|
Updated |
|
r+ ce473a1 |
Publish command Reviewed-by: MonsieurNicolas
3 participants
Description
Resolves #1814
Add new command
publishwhich publishes all (or almost all) remaining checkpoints to history archives. I may leave one unpublished in case LCL is equal to last ledger in last checkpoint, in which case we must wait for next ledger from network before progressing. Publishing of that last checkpoint is postponed to normal stellar-core run.This PR requires #1732 to be merged first
Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)