Reenable Windows builds with fix for publish-dry-run #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
leighmcculloch
force-pushed
the
supereminently-semifitting
branch
from
b34fe8c to
efd3514
Compare
graydon
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Run publish-dry-run on windows separately for each feature set that needs testing.
Why
Recently the publish-dry-run for windows started failing. This has actually been a long running issue brson/wasm-opt-rs#116 where repeated builds can't remove a file on windows between each build.
This only recently became an issue for us because in #672 we made wasm-opt part of an optional feature, and that was the first time we ever had a windows build (the publish-dry-run job) where multiple builds occurred on the same instance. It was our first feature in soroban-cli leading to the first multi-build run.
A fix has been merged to cargo in rust-lang/cargo#11442.
In 2-3 months a version of cargo should ship that has the fix.
Until then we can simply run our windows builds with each feature set getting its own isolated and fresh instance.
Also
This change also includes fixes for soroban-spec-tools and soroban-spec-typescript that had broken publishing.