Skip to content

Properly expose and use buffer sizes for OscClient and OscServer #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r618 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Properly expose and use buffer sizes for OscClient and OscServer #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Runtime/Scripts/OscClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ public class OscClient
/// <summary>Where this client is sending messages to</summary>
public IPEndPoint Destination { get; }

public OscClient(string ipAddress, int port)
public OscClient(string ipAddress, int port, int bufferCapacity = 4096)
{
m_Writer = new OscWriter();
m_Writer = new OscWriter(bufferCapacity);

m_Socket = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp);
if (ipAddress == "255.255.255.255")
Expand Down
4 changes: 2 additions & 2 deletions Runtime/Scripts/OscServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ public void Start()
/// </summary>
/// <param name="port">The port to listen for incoming message on</param>
/// <returns></returns>
public static OscServer GetOrCreate(int port)
public static OscServer GetOrCreate(int port, int bufferSize = 4096)
{
OscServer server;
if (!PortToServer.TryGetValue(port, out server))
{
server = new OscServer(port);
server = new OscServer(port, bufferSize);
PortToServer[port] = server;
}
return server;
Expand Down