Skip to content

don't run filldisk in target container cgroup #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshiste wants to merge 1 commit into
base: main
Choose a base branch
from
Open

don't run filldisk in target container cgroup #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions e2e/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// SPDX-License-Identifier: MIT
// SPDX-FileCopyrightText: 2025 Steadybit GmbH

/*
* Copyright 2024 steadybit GmbH. All rights reserved.
*/

// SPDX-License-Identifier: MIT
// SPDX-FileCopyrightText: 2023 Steadybit GmbH

package e2e

import (
Expand Down Expand Up @@ -1150,10 +1150,6 @@ func testFillDisk(t *testing.T, m *e2e.Minikube, e *e2e.Extension) {
defer func() { _ = action.Cancel() }()
require.NoError(t, err)

if testCase.method == diskfill.OverTime && testCase.wantedDelta != -1 {
e2e.AssertProcessRunningInContainer(t, m, nginx.Pod, "nginx", "dd", true)
}

if testCase.wantedDelta != -1 {
assertFileHasSize(t, m, nginx.Pod, "nginx", pathToFill+"/disk-fill", wantedFileSize, testCase.wantedDelta)
}
Expand All @@ -1164,12 +1160,6 @@ func testFillDisk(t *testing.T, m *e2e.Minikube, e *e2e.Extension) {

require.NoError(t, action.Cancel())

if testCase.method == diskfill.OverTime {
e2e.AssertProcessNOTRunningInContainer(t, m, nginx.Pod, "nginx", "dd")
} else {
e2e.AssertProcessNOTRunningInContainer(t, m, nginx.Pod, "nginx", "fallocate")
}

out, _ := m.PodExec(nginx.Pod, "nginx", "ls", pathToFill+"/disk-fill")
assert.Contains(t, out, "No such file or directory")
})
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ require (
github.com/opencontainers/runtime-spec v1.2.0
github.com/rs/zerolog v1.33.0
github.com/steadybit/action-kit/go/action_kit_api/v2 v2.9.6
github.com/steadybit/action-kit/go/action_kit_commons v1.2.17
github.com/steadybit/action-kit/go/action_kit_commons v1.2.18-0.20250131110108-eaafbe661f0f
github.com/steadybit/action-kit/go/action_kit_sdk v1.1.14
github.com/steadybit/action-kit/go/action_kit_test v1.3.2
github.com/steadybit/discovery-kit/go/discovery_kit_api v1.6.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ github.com/spf13/pflag v1.0.5/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An
github.com/spkg/bom v0.0.0-20160624110644-59b7046e48ad/go.mod h1:qLr4V1qq6nMqFKkMo8ZTx3f+BZEkzsRUY10Xsm2mwU0=
github.com/steadybit/action-kit/go/action_kit_api/v2 v2.9.6 h1:Qci7Numf66mjCIRo7KDwHUimIxUZzq+GBfyv/1f/QCU=
github.com/steadybit/action-kit/go/action_kit_api/v2 v2.9.6/go.mod h1:ycF2RLgRsB8I/jD52aE+dKZKVru1GIEtmkcRcIR3vXk=
github.com/steadybit/action-kit/go/action_kit_commons v1.2.17 h1:NOKvnUA/iZo7mlcgSK+c8EHjxAEYCLSdyk8KVQSXmv8=
github.com/steadybit/action-kit/go/action_kit_commons v1.2.17/go.mod h1:GFLcaf/WluBIqnq+iSCEGkEqxnfB9h1I16IBR1T7kNQ=
github.com/steadybit/action-kit/go/action_kit_commons v1.2.18-0.20250131110108-eaafbe661f0f h1:GHQ1ziIDxATEj4tCV1744PitgUcigScNiemK3dopXWM=
github.com/steadybit/action-kit/go/action_kit_commons v1.2.18-0.20250131110108-eaafbe661f0f/go.mod h1:GFLcaf/WluBIqnq+iSCEGkEqxnfB9h1I16IBR1T7kNQ=
github.com/steadybit/action-kit/go/action_kit_sdk v1.1.14 h1:x94RX+vh9Iyc0tS6BhiSpvknj+xE36AV0Nc3D5Yuub0=
github.com/steadybit/action-kit/go/action_kit_sdk v1.1.14/go.mod h1:Tp/klK5b7k+BCvb3JTSDZSNcnpFBaHauhndzOarnMW4=
github.com/steadybit/action-kit/go/action_kit_test v1.3.2 h1:DFDznoWEbTGv+fiGYiRaq7tq5es9VTScjrWusRAbS08=
Expand Down
Loading