New design part I.#30
Conversation
|
GustavoNunes
left a comment
There was a problem hiding this comment.
Some comments regarding conventions and maintainability. Also, if you are having trouble with the positioning, consider using flexbox instead of floats and clearfixes.
resources/public/css/style.css
Outdated
|
|
||
|
|
||
| .slick-slider{ | ||
| margin-bottom: 0 !important; |
There was a problem hiding this comment.
Lets avoid !important here and elsewhere unless absolutely necessary.
resources/public/css/style.css
Outdated
| font-size: 20px; | ||
| } | ||
| .wallet-amount p.left-block { | ||
| flot:left |
src/cljs/token/wallet/page.cljs
Outdated
| send-amount (subscribe [:get :send-amount]) | ||
| request-amount (subscribe [:get :request-amount]) | ||
| text (subscribe [:get :text])] | ||
| text (subscribe [:get :text])] |
There was a problem hiding this comment.
Let's keep the previous indentation, it reads better.
src/cljs/token/wallets/page.cljs
Outdated
|
|
||
| (defn wallet-uri [wallet-id] | ||
| [:a.wallet-btn {:href (str "#/wallet/" wallet-id)} "Open wallet"]) | ||
| (defn allTransactions [] |
There was a problem hiding this comment.
Lets use all-transactions here. Refer to https://github.com/bbatsov/clojure-style-guide#lisp-case.
| [:span.wallet-currencies | ||
| [:div.currency-usd | ||
| (to-fixed (:amount balance-fmt) 4) [:span.cur (:unit balance-fmt)]]] | ||
| ] [:div.clearfix]])))) |
There was a problem hiding this comment.
These clearfix forms, here and elsewhere, should be indented like the others.
src/cljs/token/wallets/page.cljs
Outdated
| [:div.wallet.manage-wallet | ||
| [:div.wallet-name "Manage wallets"] | ||
| [:span.wallet-points | ||
| [:div.point] [:div.point] [:div.point]] |
There was a problem hiding this comment.
This implementation of the ellipsis is not responsive. Try using a single element as an image, svg or even text ("...").
|
Thanks for the changes @ajandera! Here are some more issues I found while testing in a small screen.
|
|
Hi Gustavo, i updated a PR, please look at it, can you please send me the images for transaction icons? I update transaction history part and need the icon to finish, or is there a way to get icons from zeplin? |


Changes of css, main page and wallet detail without transactions.