Skip to content

Conversation

@Solpatium
Copy link
Contributor

Split from #11

@@ -0,0 +1,112 @@
#ifndef STARKWARE_CRYPTO_FFI_PORTABLE_ENDIAN_H_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you strip the license header?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I strip it from https://github.com/sahlberg/libsmb2/blob/master/include/portable-endian.h since author placed in public domain.

Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @Solpatium)


src/starkware/crypto/ffi/utils.cc line 1 at r1 (raw file):

#include <endian.h>

This should be removed now, right?

Code quote:

#include <endian.h>

@Solpatium
Copy link
Contributor Author

Good catch, I missed it after the split from the initial PR. Sorry 😅

Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Solpatium)

@ilyalesokhin-starkware ilyalesokhin-starkware merged commit 78e3ed8 into starkware-libs:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants