Fixed brcode attribute from Invoice Pull Subscription and updated tests #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_success(self): | ||
| requests = list(starkbank.invoicepullrequest.query(limit=5)) | ||
| print(f"Number of InvoicePullRequests: {len(requests)}") | ||
| i = 0 |
Contributor
There was a problem hiding this comment.
Não seria melhor definir uma variável limit = 5 e depois fazer assertEqual(limit, len(requests)?
Não sei como que está o padrão nos outros testes do SDK
Contributor
Author
There was a problem hiding this comment.
Temos nesse formato nos testes de Invoice:
invoices, cursor = starkbank.invoice.page(limit=2, cursor=cursor)
invoices = starkbank.invoice.query(limit=10)
Também em boleto:
boletos, cursor = starkbank.boleto.page(limit=2, cursor=cursor)
boletos = starkbank.boleto.query(limit=1)
| def test_success(self): | ||
| subscriptions = list(starkbank.invoicepullsubscription.query(limit=5)) | ||
| print(f"Number of InvoicePullSubscriptions: {len(subscriptions)}") | ||
| i = 0 |
paulosouza-stark
force-pushed
the
fix/invoice-pull-subscription-brcode
branch
from
1a7a914 to
0af58f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed