feat(hooks): add thinking_budget hook for extended thinking management#5
Draft
nmarasoiu wants to merge 1 commit intostarbaser:mainfrom
Draft
feat(hooks): add thinking_budget hook for extended thinking management#5nmarasoiu wants to merge 1 commit intostarbaser:mainfrom
nmarasoiu wants to merge 1 commit intostarbaser:mainfrom
Conversation
6b20e94 to
4ffd06a
Compare
Add a new hook that manages Claude's extended thinking budget_tokens parameter: - Inject default budget_tokens when thinking is enabled but budget is missing - Override budget_tokens when below configurable minimum threshold - Ensure budget < max_tokens (API constraint) - Optionally inject thinking configuration for thinking-capable models Key design decisions: - Trust caller: if request has thinking, adjust budget regardless of model - Model filter only applies to inject_if_missing mode - Anthropic-specific: non-Anthropic providers will ignore thinking field - Simple config via hook params (no env var complexity) Configuration: - budget_default: Default budget (10000) - budget_min: Minimum threshold (1024) - inject_if_missing: Auto-inject thinking (false) - log_modifications: Log changes (true)
4ffd06a to
09bb994
Compare
Owner
|
Thanks for the PR, and another thank you for your patience. After looking through this, I kind of see where you're going with it, but first thing I'd want from you is a more focused value proposition. Some things to note:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Not sure if this is useful.
In case of Claude Code, using keywords like think, think hard & ultrathink go a long way of setting a thinking budget.
For non Claude thinking models, the http parameters might be different so not sure this would work beyond Anthropic.
Add a new hook that manages Claude's extended thinking budget_tokens parameter:
Key design decisions:
Configuration: