Skip to content

Conversation

@philvarner
Copy link
Contributor

@philvarner philvarner commented Dec 15, 2025

What I'm changing

Previously, all of the dependencies across every workspace were installed and then the tests run. This is bad because packages can be used in code and pass tests even though the dependency is not correcly defined in the workspace's pyproject.toml.

How I did it

  • refactored the workspace pyproject.toml's to have dev dependencies necessary to run pytest
  • created a test running script to install only the dependencies for each workspace and run their tests.

Checklist

  • Tests pass: uv run pytest
  • Checks pass: uv run pre-commit run --all-files
  • CHANGELOG is updated (if necessary)

@philvarner philvarner changed the title remove fastapi[standard] from dev dependencies Rework dependencies and how pytest is run Dec 16, 2025
@philvarner philvarner marked this pull request as ready for review December 16, 2025 01:14
@philvarner philvarner requested a review from gadomski as a code owner December 16, 2025 01:14
@philvarner philvarner requested a review from wevonosky December 16, 2025 16:06
@philvarner philvarner enabled auto-merge (squash) December 16, 2025 16:06
@philvarner philvarner merged commit 2e5def5 into main Dec 16, 2025
4 checks passed
@philvarner philvarner deleted the pv/build branch December 16, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants