Fix concurrent dictionary access bugs#1
Draft
kimrypstra wants to merge 5 commits intostanfeldman:masterfrom
Draft
Fix concurrent dictionary access bugs#1kimrypstra wants to merge 5 commits intostanfeldman:masterfrom
kimrypstra wants to merge 5 commits intostanfeldman:masterfrom
Conversation
kimrypstra
force-pushed
the
Update-Swift
branch
from
30f3fd6 to
be4f7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We've had some issues that seem to be related to concurrent access of the
DependencyResolver.sharedInstancesdictionary. So I changedDependencyResolverto anactoras it's designed to regulate access to shared state.After increasing the deployment target to iOS 13, tests no longer ran due to the removal of a dependency inside Nimble. So I also bumped Nimble and Quick, and fixed the tests.