build(deps): bump get-stdin from 8.0.0 to 9.0.0#238
build(deps): bump get-stdin from 8.0.0 to 9.0.0#238dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
dependabot
bot
added
dependencies
There was a problem hiding this comment.
Requested for reviews since this is a BREAKING CHANGE.
Also I edited the code, I don't know if it would be better that I open a PR myself instead to do this with this dependabot PR.
I think it is fine to drop support for Node.js v10 since it reached end of life, also ESM import are so cleaner than require to write and I think it is the right thing to do to move gradually all npm packages to use this "new" syntax instead of ugly CommonJS (standard included). 😄
I will open others PRs to implement ESM in others repo of the standard org, if it is wanted once this PR has been merged.
index.js
Outdated
| import os from 'node:os' | ||
| import path from 'node:path' | ||
| import pkgConf from 'pkg-conf' | ||
| import { cache as xdgCache } from 'xdg-basedir' |
There was a problem hiding this comment.
Once this PR has been merged, we will be able to update xdg-basedir too (see #236) to do that, we will need to remove cache as from this statement.
theoludwig
left a comment
theoludwig
left a comment
There was a problem hiding this comment.
With a little bit more of research, I think it is still too early, hopefully the tools and the ecosystem will gradually move to ESM instead of CommonJS, but we should wait before making the move.
I will put this PR as draft for the moment, hopefully, later this year, we will be able to sucessfully migrate. 👍
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/get-stdin-9.0.0
branch
2 times, most recently
from
656b768 to
84f7bb4
Compare
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/get-stdin-9.0.0
branch
from
84f7bb4 to
f019a56
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/get-stdin-9.0.0
branch
from
f019a56 to
a752fa3
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/get-stdin-9.0.0
branch
from
a752fa3 to
dd9d4a0
Compare
Bumps [get-stdin](https://github.com/sindresorhus/get-stdin) from 8.0.0 to 9.0.0. - [Release notes](https://github.com/sindresorhus/get-stdin/releases) - [Commits](sindresorhus/get-stdin@v8.0.0...v9.0.0) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/get-stdin-9.0.0
branch
from
dd9d4a0 to
0d6541e
Compare
2 participants
Bumps get-stdin from 8.0.0 to 9.0.0.
Release notes
Sourced from get-stdin's releases.
Commits
147d91c9.0.08f70f58Require Node.js 12 and move to ESMa326009Move to GitHub ActionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)