Skip to content

Cache directory respects XDG_CACHE_HOME (basedir spec) #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feross merged 3 commits into from
Oct 27, 2020
Merged

Cache directory respects XDG_CACHE_HOME (basedir spec) #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97aa9b7
Adds xdg-basedir dep
jasonkarns May 4, 2020
0c920fa
Respect XDG Basedir Spec for cache location
jasonkarns Mar 20, 2020
1a9c851
Update index.js
jasonkarns May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var os = require('os')
var path = require('path')
var pkgConf = require('pkg-conf')

var HOME_OR_TMP = os.homedir() || os.tmpdir()
var CACHE_HOME = require('xdg-basedir').cache || os.tmpdir()
Copy link
Contributor

@mightyiam mightyiam May 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference:

https://github.com/sindresorhus/xdg-basedir/blob/a8b4130c61413006f1716d84b92a5ffd6e9336e8/index.js#L14
https://nodejs.org/api/os.html#os_os_tmpdir

Makes sense.


var DEFAULT_PATTERNS = [
'**/*.js',
Expand Down Expand Up @@ -38,8 +38,8 @@ function Linter (opts) {
var m = opts.version && opts.version.match(/^(\d+)\./)
var majorVersion = (m && m[1]) || '0'

// Example cache location: .standard-v12-cache/
var cacheLocation = path.join(HOME_OR_TMP, `.${this.cmd}-v${majorVersion}-cache/`)
// Example cache location: ~/.cache/standard/v12/
Copy link
Contributor

@mightyiam mightyiam May 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest this comment be removed. It may be understood that that is the only possible pattern.

Suggested change
// Example cache location: ~/.cache/standard/v12/

var cacheLocation = path.join(CACHE_HOME, this.cmd, `v${majorVersion}/`)

this.eslintConfig = Object.assign({
cache: true,
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
"deglob": "^4.0.1",
"get-stdin": "^7.0.0",
"minimist": "^1.2.5",
"pkg-conf": "^3.1.0"
"pkg-conf": "^3.1.0",
"xdg-basedir": "^4.0.0"
},
"devDependencies": {
"babel-eslint": "^10.1.0",
Expand Down