Fix validators checker #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ValidatorsChecker contracts by adding support for genesis vault pool escrow functionality. The changes ensure that genesis vaults properly account for assets held in their associated pool escrow contracts when calculating total vault assets.
- Adds
genesisVaultPoolEscrowparameter to ValidatorsChecker constructors - Updates asset calculation logic to include pool escrow balances for genesis vaults
- Updates deployment configurations with new ValidatorsChecker addresses
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/validators/ValidatorsChecker.sol | Adds pool escrow parameter to base constructor and stores it as immutable field |
| contracts/validators/GnoValidatorsChecker.sol | Implements genesis vault detection and includes pool escrow assets in GNO calculations |
| contracts/validators/EthValidatorsChecker.sol | Implements genesis vault detection and includes pool escrow ETH balance |
| test/gnosis/GnoValidatorsChecker.t.sol | Updates test constructor to pass pool escrow parameter |
| test/EthValidatorsChecker.t.sol | Updates test constructor to pass pool escrow parameter |
| script/UpgradeGnoNetwork.s.sol | Updates deployment script to include pool escrow parameter |
| script/UpgradeEthNetwork.s.sol | Updates deployment script to include pool escrow parameter |
| deployments/*.json | Updates ValidatorsChecker contract addresses across all networks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Forge code coverage:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.