Skip to content

Conversation

@xoxys
Copy link
Member

@xoxys xoxys commented Dec 18, 2025

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

Instead of using two different config formats (YAML and INI) the code was reworked to use the same YAML config for both CCM and CSI.

Special notes for your reviewer:

Breaking changes:

/hold

This change is breaking. Users must migrate their deployments for both CCM and CSI to the new YAML configuration. Even with the existing YAML configuration, the structure and names of the options have changed and must be adjusted.

@ske-prow
Copy link

ske-prow bot commented Dec 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jamand for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2025
@xoxys xoxys added enhancement New feature or request do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 18, 2025
@xoxys xoxys requested a review from a team December 18, 2025 09:09
@xoxys xoxys added kind/enhancement Enhancement, improvement, extension and removed enhancement New feature or request labels Dec 18, 2025
@ske-prow ske-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Dec 18, 2025
@breuerfelix
Copy link
Member

/lgtm

@ske-prow ske-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2025
@ske-prow
Copy link

ske-prow bot commented Dec 19, 2025

LGTM label has been added.

DetailsGit tree hash: 489dd538c55e6d1ccab62eaad56d6688914f958e

@ske-prow ske-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@ske-prow ske-prow bot requested a review from breuerfelix December 22, 2025 08:11
@ske-prow
Copy link

ske-prow bot commented Dec 22, 2025

New changes are detected. LGTM label has been removed.

@ske-prow ske-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants