-
Notifications
You must be signed in to change notification settings - Fork 2
feat(dom): DOM - toHaveStyle #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SbsCruz
wants to merge
13
commits into
main
Choose a base branch
from
feat/dom-have-style
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d04e662
Chore: added parse lib from adobe
SbsCruz 47095a4
Add: toHaveStyle first approach
SbsCruz 7856c46
Add: toHaveStyle tests first approach
SbsCruz c0fa1ca
Refactor: toHaveStyle class
SbsCruz 7fdbe4e
Add: test for when styles are the same and the opposite case
SbsCruz 44519ed
Add: Funcionality for object cases
SbsCruz bff87ff
Add: Assertion execution
SbsCruz 2b7bb5a
Add: functions moved into helpers and implemeneted in class
SbsCruz 74c64f4
Add: refactored test
SbsCruz 1c788c1
Add: simplified logic and refactored functions
SbsCruz 35da1bf
Add: test for partial match
SbsCruz f96358d
refactor: logic improved
SbsCruz e8e60db
chore: removed @adobe/css-tools since it's not longer used
SbsCruz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| interface StyleDeclaration extends Record<string, string> { | ||
| property: string; | ||
| value: string; | ||
| } | ||
|
|
||
| function normalizeStyles(css: Partial<CSSStyleDeclaration>): StyleDeclaration { | ||
| const normalizer = document.createElement("div"); | ||
| document.body.appendChild(normalizer); | ||
|
|
||
| const { expectedStyle } = Object.entries(css).reduce( | ||
| (acc, [property, value]) => { | ||
|
|
||
| if (typeof value !== "string") { | ||
| return acc; | ||
| } | ||
|
|
||
| normalizer.style.setProperty(property, value); | ||
|
|
||
| const normalizedValue = window | ||
| .getComputedStyle(normalizer) | ||
| .getPropertyValue(property) | ||
| .trim(); | ||
|
|
||
| return { | ||
| expectedStyle: { | ||
| ...acc.expectedStyle, | ||
| [property]: normalizedValue, | ||
| }, | ||
| }; | ||
| }, | ||
| { expectedStyle: {} as StyleDeclaration }, | ||
| ); | ||
|
|
||
| document.body.removeChild(normalizer); | ||
|
|
||
| return expectedStyle; | ||
| } | ||
|
|
||
| function getReceivedStyle (props: string[], received: CSSStyleDeclaration): StyleDeclaration { | ||
|
|
||
| return props.reduce((acc, prop) => { | ||
|
|
||
| const actualStyle = received.getPropertyValue(prop).trim(); | ||
|
|
||
| return actualStyle | ||
| ? { ...acc, [prop]: actualStyle } | ||
| : acc; | ||
|
|
||
| }, {} as StyleDeclaration); | ||
| } | ||
|
|
||
| export const getExpectedAndReceivedStyles = | ||
| (actual: Element, expected: Partial<CSSStyleDeclaration>): StyleDeclaration[] => { | ||
| if (!actual.ownerDocument.defaultView) { | ||
| throw new Error("The element is not attached to a document with a default view."); | ||
| } | ||
| if (!(actual instanceof HTMLElement)) { | ||
| throw new Error("The element is not an HTMLElement."); | ||
| } | ||
|
|
||
| const window = actual.ownerDocument.defaultView; | ||
|
|
||
| const rawElementStyles = window.getComputedStyle(actual); | ||
|
|
||
| const expectedStyle = normalizeStyles(expected); | ||
|
|
||
| const styleKeys = Object.keys(expectedStyle); | ||
|
|
||
| const elementProcessedStyle = getReceivedStyle(styleKeys, rawElementStyles); | ||
|
|
||
| return [ | ||
| expectedStyle, | ||
| elementProcessedStyle, | ||
| ]; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.