Skip to content

coverage#1

Draft
omriss wants to merge 84 commits intomainfrom
dev
Draft

coverage#1
omriss wants to merge 84 commits intomainfrom
dev

Conversation

@omriss
Copy link
Collaborator

@omriss omriss commented Dec 22, 2025

No description provided.

@stability-builder
Copy link

Good luck!

/// @notice Authority contract holding addresses of core contracts and managing access to all contracts of Host platform
contract Authority is AccessManager, IAuthority {
/// @inheritdoc IAuthority
address public immutable HOST;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Variable Authority.HOST is not in mixedCase
address public immutable HOST;

/// @inheritdoc IAuthority
address public immutable PROXY_FACTORY;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Variable Authority.PROXY_FACTORY is not in mixedCase
/// @author omriss (https://github.com/omriss)
contract ProxyFactory is IProxyFactory, Ownable {
/// @notice Address of the master Proxy contract to be cloned
address public immutable MASTER_PROXY;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable ProxyFactory.MASTER_PROXY (src/ProxyFactory.sol#15) is not in mixedCase
address public immutable MASTER_PROXY;

/// @dev Keccak256 hash of the init code of the clone of the master Proxy contract
bytes32 internal immutable MASTER_PROXY_CLONE_CODE_HASH;

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions

Variable ProxyFactory.MASTER_PROXY_CLONE_CODE_HASH (src/ProxyFactory.sol#18) is not in mixedCase

interface IAuthority is IAccessManager {
/// @notice Address of Host contract on the current chain
function HOST() external view returns (address);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Function IAuthority.HOST() is not in mixedCase
function HOST() external view returns (address);

/// @notice Address of ProxyFactory used to deploy the proxy contracts
function PROXY_FACTORY() external view returns (address);

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Function IAuthority.PROXY_FACTORY() is not in mixedCase
/// @inheritdoc IAuthority
address public immutable PROXY_FACTORY;

constructor(address initialAdmin, address host_, address proxyFactory_) AccessManager(initialAdmin) {

Check notice

Code scanning / Slither

Missing zero address validation Low

/// @inheritdoc IAuthority
address public immutable PROXY_FACTORY;

constructor(address initialAdmin, address host_, address proxyFactory_) AccessManager(initialAdmin) {

Check notice

Code scanning / Slither

Missing zero address validation Low

Comment on lines +77 to +80
function _initProxy(address proxy, address implementation, bytes memory data_) internal {
IProxy(proxy).initProxy{value: msg.value}(implementation, data_);
emit ProxyCreated(proxy);
}

Check notice

Code scanning / Slither

Reentrancy vulnerabilities Low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants