Don't disable javadoc publishing + make release job wait #2076
Conversation
| manifest { attributes("Automatic-Module-Name" to "com.squareup.moshi.adapters") } | ||
| } | ||
|
|
||
| configure<MavenPublishBaseExtension> { configure(KotlinJvm(javadocJar = None())) } |
There was a problem hiding this comment.
Does this prevent it from publishing? Or do we get some default behaviour? In Okio we do this:
configure<MavenPublishBaseExtension> {
configure(
KotlinMultiplatform(javadocJar = JavadocJar.Empty())
)
}
There was a problem hiding this comment.
Applying the plugin alone is enough I think since we have this auto-configuring from the root project on subprojects. This line seemed to just disable javadoc jars, which is what was breaking sonatype's validation per @gabrielittner
There was a problem hiding this comment.
Worst case it still fails validation and we try something else 😅
There was a problem hiding this comment.
When you apply the base plugin you need to call one of the configure methods from the DSL. There are cases where we just configure publications created by others then it might still work, in other cases nothing will get published at all
There was a problem hiding this comment.
Hmmm I missed the "base" bit. I'm not sure why we have that tbh, stuck a PR up here to remove that and use the standard setup: #2077
No description provided.