Skip to content

Fix unknown escape sequences in string literals to preserve backslash #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 1 commit into from
Dec 25, 2025
Merged

Fix unknown escape sequences in string literals to preserve backslash #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lexer/lexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,8 @@ func (l *Lexer) readString(quote rune) Item {
val := hexValue(hex1)*16 + hexValue(hex2)
sb.WriteByte(byte(val))
default:
// Unknown escape, just write the character after backslash
// Unknown escape, preserve both the backslash and the character
sb.WriteRune('\\')
sb.WriteRune(l.ch)
}
l.readChar()
Expand Down
2 changes: 1 addition & 1 deletion parser/testdata/01497_extract_all_groups_empty_match/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"todo": true}
{}
2 changes: 1 addition & 1 deletion parser/testdata/01847_bad_like/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"todo": true}
{}
2 changes: 1 addition & 1 deletion parser/testdata/02374_regexp_replace/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"todo": true}
{}
2 changes: 1 addition & 1 deletion parser/testdata/02580_like_substring_search_bug/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"todo": true}
{}
2 changes: 1 addition & 1 deletion parser/testdata/03031_input_format_allow_errors_num_bad_escape_sequence/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"todo": true}
{}