Skip to content

Fix SHOW DATABASES EXPLAIN AST output to match ClickHouse #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 1 commit into from
Dec 23, 2025
+3 −3
Merged

Fix SHOW DATABASES EXPLAIN AST output to match ClickHouse #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/explain/statements.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,8 @@ func explainExplainQuery(sb *strings.Builder, n *ast.ExplainQuery, indent string
func explainShowQuery(sb *strings.Builder, n *ast.ShowQuery, indent string) {
// ClickHouse maps certain SHOW types to ShowTables in EXPLAIN AST
showType := strings.Title(strings.ToLower(string(n.ShowType)))
// SHOW SETTINGS is displayed as ShowTables in ClickHouse
if showType == "Settings" {
// SHOW SETTINGS and SHOW DATABASES are displayed as ShowTables in ClickHouse
if showType == "Settings" || showType == "Databases" {
showType = "Tables"
}
fmt.Fprintf(sb, "%sShow%s\n", indent, showType)
Expand Down
2 changes: 1 addition & 1 deletion parser/testdata/02902_show_databases_limit/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"todo": true}
{}