Documentation: Syntax error in Github.create #224

[Black-Smith-Of-Fire]

While trying the api, I found the documentation to contain errors regarding the create method of the GithubClient. I hope this small edit would help others to avoid the similar problems

[Abhi347]

The method is defined as

public static GitHubClient create(final URI baseUrl, final File privateKey, final Integer appId){}

There's no create overload (AFAIK) which accepts URI for the private key. There's one which takes byte[] instead.
Can you show the code where we are accepting URI instead of File?

[Black-Smith-Of-Fire]

I see what you mean at line number 191 in the com.spotify.github.v3.clients.GitHubClient class, but why can't I pass File in the second parameter ? Line number 179 is the create overload that I am talking about. We are using version number 0.4.1, right ?

[Abhi347]

Closing this as the issue is resolved as discussed in #224