Skip to content

BREAKING CHANGE: Remove shaded dependencies and use HttpClient interface #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhi347 merged 11 commits into from
Mar 17, 2025

Merge branch 'master' into breaking-change/remove-shading-http

c64c195
Select commit
Loading
Failed to load commit list.
Merged

BREAKING CHANGE: Remove shaded dependencies and use HttpClient interface #219

Merge branch 'master' into breaking-change/remove-shading-http
c64c195
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 17, 2025 in 0s

77.46% (+0.56%) compared to 13c7a91

View this Pull Request on Codecov

77.46% (+0.56%) compared to 13c7a91

Details

Codecov Report

Attention: Patch coverage is 74.54910% with 127 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (13c7a91) to head (c64c195).

Files with missing lines Patch % Lines
...va/com/spotify/github/v3/clients/GitHubClient.java 73.63% 65 Missing and 12 partials ⚠️
...m/spotify/github/http/okhttp/OkHttpHttpClient.java 77.10% 17 Missing and 2 partials ⚠️
...spotify/github/http/okhttp/OkHttpHttpResponse.java 64.00% 5 Missing and 4 partials ⚠️
...in/java/com/spotify/github/tracing/NoopTracer.java 46.15% 7 Missing ⚠️
...m/spotify/github/v3/clients/PullRequestClient.java 66.66% 5 Missing and 2 partials ⚠️
...java/com/spotify/github/http/BaseHttpResponse.java 88.88% 0 Missing and 2 partials ⚠️
...in/java/com/spotify/github/tracing/BaseTracer.java 88.23% 2 Missing ⚠️
...hub/tracing/opentelemetry/OpenTelemetryTracer.java 33.33% 2 Missing ⚠️
...main/java/com/spotify/github/http/HttpRequest.java 88.88% 0 Missing and 1 partial ⚠️
...om/spotify/github/v3/clients/RepositoryClient.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     76.89%   77.46%   +0.56%     
- Complexity      381      417      +36     
============================================
  Files            56       60       +4     
  Lines          1277     1367      +90     
  Branches         51       59       +8     
============================================
+ Hits            982     1059      +77     
- Misses          264      265       +1     
- Partials         31       43      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov