Conversation
fabriziodemaria
changed the title
fabriziodemaria
changed the title
fabriziodemaria
force-pushed
the
unrec-rule
branch
from
a69c188 to
9132ff0
Compare
Updated the flag resolution logic to skip unrecognized targeting rules instead of returning an error. Added a test to ensure that unrecognized rules do not cause the flag resolution to fail, confirming that the expected behavior is maintained.
fabriziodemaria
force-pushed
the
unrec-rule
branch
from
9132ff0 to
678ca31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to avoid: "all the rules you might have had there for 6 months suddenly stops getting traffic when you add something new"