refactor: process resolve for materialization#275
Merged
andreas-karlsson merged 10 commits intomainfrom Feb 20, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...-provider/java/src/main/java/com/spotify/confidence/sdk/OpenFeatureLocalResolveProvider.java
Outdated
Show resolved
Hide resolved
| resolveWithContext( | ||
| List.of(flag1), "a".repeat(101), Struct.newBuilder().build(), false)) | ||
| .withMessageContaining("Targeting key is too larger, max 100 characters."); | ||
| // Targeting key > 100 chars results in a TargetingKeyError reason, not an exception |
Contributor
Author
There was a problem hiding this comment.
This is a change in semantics. I think it's harmless, but maybe we should still treat it as an error?
Contributor
Author
There was a problem hiding this comment.
I left this change so it's now a targeting-key-error.
nicklasl
reviewed
Feb 16, 2026
nicklasl
reviewed
Feb 17, 2026
andreas-karlsson
force-pushed
the
materialization-refactor
branch
from
aeb5ac8 to
5bbb929
Compare
Co-authored-by: Nicklas Lundin <nicklasl@spotify.com>
andreas-karlsson
force-pushed
the
materialization-refactor
branch
from
c48e977 to
fac33fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the materialization API to use a suspend/resume pattern.
Key changes:
New
ResolveProcessRequestAPI with four modes:DeferredMaterializations- suspend if materializations neededStaticMaterializations- provide materializations upfrontWithoutMaterializations- error if materializations neededResume- continue after fetching materializationsUnified
MaterializationRecordreplaces separateReadOp,ReadResult,VariantData,InclusionDatatypesKleene logic for expression evaluation - unknown materialization state evaluates to
Unknown(not true/false), guaranteeing all needed materializations are discovered in a single passSingle suspend/resume cycle - no retry loops needed
Removed
wasm_msg_guest_resolveexport (replaced bywasm_msg_guest_resolve_flags)