Update SDL2 and move to using submodules#7
Open
hugglesfox wants to merge 4 commits intosplashkit:masterfrom
Open
Update SDL2 and move to using submodules#7hugglesfox wants to merge 4 commits intosplashkit:masterfrom
hugglesfox wants to merge 4 commits intosplashkit:masterfrom
Conversation
Additionally update the SDL lib versions to latest stable. Note that SDL_gfx is hosted on sourceforge (not git) and therefore the source tree is directly bundled.
Originally it was bundled with the SDL_image headers
This reduces the download size as git just gets the latest commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the SDL2 headers to the latest version which I've through converting them to submodules. The benefits of this being that only the .gitmodules file needs to be modified to update the sdl versions (as apposed to copy/pasting the header files from each SDL project). This does come at the drawback that all of the SDL project files are cloned down via the submodules however they are shallowly cloned (only the latest commit) and recursion is disabled.
Tested on windows. Not tested on Mac