Ensure consistent X.509 SVID and bundle reads in DefaultX509Source#397
Merged
maxlambrecht merged 2 commits intospiffe:mainfrom Jan 22, 2026
Merged
Conversation
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
rturner3
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
DefaultX509Sourceto publish the X.509 SVID and bundle set as a single immutable snapshot. This avoids transient inconsistent reads during Workload API updates while preserving existing behavior and avoiding additional locking on the read path.The previous implementation synchronized only the update path while allowing unsynchronized reads, which could observe mismatched (SVID, bundle set) pairs. Publishing a snapshot via a volatile reference ensures atomic, consistent visibility across threads.