Conversation
SomberNight
reviewed
Jan 10, 2023
ecdsa
force-pushed
the
scid_alias
branch
2 times, most recently
from
7ec4f00 to
dbb3462
Compare
SomberNight
reviewed
Jan 13, 2023
Note: there are no more optional fields in msgdata, per lightning/bolts@f068dd0
- save remote alias for use in invoices - derive local alias from wallet xpub - send channel_type without the option_scid_alias bit (apparently LND does not like it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit updates the CSV files in
lnwire. Apparently some options are no longer generated by the script (were they before?), and need to be added manually (see notes in README)The second commit add
option_scid_alias. There are quite some differences in the behaviour of Eclair and LND, see comments in the code.