Conversation
Updates the closing fee negotiation to comply with most recent spec changes, see lightning/bolts#847 The closing negotiation is backwards compatible with the old negotiation.
ecdsa
force-pushed
the
modern_fee_negotiation
branch
from
e45828a to
d22b7f3
Compare
3 tasks
ecdsa
force-pushed
the
modern_fee_negotiation
branch
from
d22b7f3 to
c90f87c
Compare
- the fee negotiation is split into smaller functions, reducing the scope of variables. - the while loop logic is condensed in a few lines, so it is easier to understand termination conditions. - removed code that was never executed
- clarify TODOs - add tests for shutdown with modern negotiation
ecdsa
force-pushed
the
modern_fee_negotiation
branch
from
c90f87c to
6667a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #7586
I refactored the code in
_shutdown:whileloop logic is condensed in a few lines, so it is easier to understand termination conditions.