Fix dependencies, Support for more TTS engines and short-form IPA #104
Conversation
…vices-emal3u fix: restore dedicated Microsoft SAPI formatter
|
Hi @willwade, thanks for your contribution! This looks like quite an update indeed. I have briefly skimmed through it and it looks quite thorough. At the moment I am not using this library for anything but if CI passes I' happily merge / publish. Let's ping @rmtuckerphx as well to see if he approves as well. |
|
Cheers. If it's ok It will be handy to get to npm so I can fully test it out in some downstream projects (eg js-tts-wrapper - it will just help a heap of issues I've got). I'm sure I'll find more probs though.. but publishing would be handy. Note. My spidey sense tells me the short code to ipa could be the most problematic thing. |
|
Ps seen the tests failing. Let me fix that |
|
You might as well remove those old Node versions and replace with just v22 and 24 |
- Upgraded Prettier to 2.8.8 and added repo-wide format scripts so optional chaining parses correctly (package.json:32, package.json:48). - Added a .prettierignore to keep generated artifacts out of formatting runs (.prettierignore:1). - Pointed the workflow’s formatting step at the new npm script for consistent CI behavior (.github/workflows/test.yml:28). - Ran npm run format to align code, tests, docs, and configs with the updated Prettier rules. - Local checks: npm run format:check, npm run lint, npm test.
Updated the CI matrix to target Node 22 and 24. Formatting verified with npm run format:check. and basic node to 22
|
@arjan I've updated node - and note - I've updated the workflow a little - I feel this is the way you'd do this now |
|
Looks great like this, thanks! |
2 participants
A myriad of things in this PR - sorry about that.
All linting. I cant say 100% its producing exceptional downstream markup - but Im fairly confident...