Add skip_reset option to BMI270::begin* methods, preventing soft reset during init#4
Closed
disq wants to merge 1 commit intosparkfun:mainfrom
Closed
Add skip_reset option to BMI270::begin* methods, preventing soft reset during init#4disq wants to merge 1 commit intosparkfun:mainfrom
skip_reset option to BMI270::begin* methods, preventing soft reset during init#4disq wants to merge 1 commit intosparkfun:mainfrom
Conversation
…reset during init
Collaborator
|
Hi there, thanks for your contribution! Unfortunately, I don't think we'll accept this PR as it is, because it modifies the underlying BMI270 API from Bosch. We're reluctant to modify their API, because if they roll out an update that we want to merge, then it's very likely to lead to merge conflicts. I do think this is a good feature though, so I would suggest creating a similar PR in the Bosch BMI270 repo. If they accept it and roll out a new release, then we can bring in those changes and update the Arduino library to match. |
Author
|
Opened boschsensortec/BMI270_SensorAPI#24 we'll see how it goes. |
Collaborator
|
Great! I think I'll close this PR for now. If and when Bosch adds that feature, then please follow up and we can add that feature here too. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
skip_resetto the following methods:Useful when waking up from sleep and the IMU has already initialized. Preventing the soft reset lets us read IMU regs to get activity data (such as step count) while we were asleep.