alps: add v2.3.4, modify maintainers & license by Ooolab · Pull Request #3530 · spack/spack-packages

Ooolab · 2026-02-24T06:51:52Z

In this updated spack package, we added support for newer versions of Boost and macOS26.

Updated versions and URLs for ALPS package. Added support for newer Boost versions.

update alps version

Removed unnecessary blank lines in package.py.

Sinan81 · 2026-02-25T04:39:34Z

repos/spack_repo/builtin/packages/alps/package.py

-    url = "https://github.com/ALPSim/ALPS/archive/refs/tags/v2.3.3-beta.5.tar.gz"

-    maintainers("Sinan81")
+    maintainers("Ooolab", "egull")


This usually means maintainer for the spack package file, as opposed to the maintainer for the software itself. So, I would recommend keeping me as maintainer alongside the others listed here. But it's up to you.

Thank you for a fast review! I have updated the package according to your suggestions. Thank you for your continued support for ALPS!

Sinan81 · 2026-02-25T04:44:29Z

repos/spack_repo/builtin/packages/alps/package.py

-        "2.3.3-beta.6", sha256="eb0c8115b034dd7a9dd585d277c4f86904ba374cdbdd130545aca1c432583b68"
+        "2.3.4-beta.2",
+        sha256="ca2e1307630e6fccac279ab7711036f7c6dee43c386fd6f24cfc77c86a3c7f1c",
+        url="https://github.com/ALPSim/ALPS/archive/refs/tags/v2.3.4-beta.2.tar.gz",


as far as I can tell, there's no need for a different url for every version here. Spack automatically converts the deleted url = ... statement to the correct one for a given version. When the url pattern changes between versions (which's not the case here I think), in Spack we usually use url_for_version method to handle different patterns.

It has been updated.

Sinan81 · 2026-02-25T04:53:13Z

repos/spack_repo/builtin/packages/alps/package.py

    depends_on("py-numpy", type=("build", "run"))
    depends_on("py-scipy", type=("build", "run"))
    depends_on("py-matplotlib", type=("build", "run"))
+    depends_on("mpi")


ALPS can be built without MPI right? if so, you might want to add a variant like:

variant("mpi", default=False, description="Build with MPI support")

afterwards, do like:

depends_on("mpi", when="+mpi")

added conditional MPI support through the variant "mpi"

Sinan81 · 2026-02-25T04:56:15Z

repos/spack_repo/builtin/packages/alps/package.py

-    )
+    depends_on("boost@1.80:")  # Just for headers. Note that the checksums are listed below
    depends_on("fftw")
    depends_on("hdf5 ~mpi+hl")


if building with mpi and and also want to use hdf5 built with mpi, you could add the following

depends_on("hdf5+mpi+hl", when="+mpi")

Sinan81 · 2026-02-25T04:59:51Z

repos/spack_repo/builtin/packages/alps/package.py

+        # Add MPI support - just specify compilers (minimal change)
+        args.append("-DMPI_CXX_COMPILER={0}".format(self.spec["mpi"].mpicxx))
+
+        args.append("-DMPI_C_COMPILER={0}".format(self.spec["mpi"].mpicc))


if defining an mpi variant mentioned above, then these should be added only if "+mpi" variant is selected.

Sinan81 · 2026-02-25T05:00:31Z

repos/spack_repo/builtin/packages/alps/package.py

+        # For MPI - set compiler wrappers
+        env.set("MPI_CXX", self.spec["mpi"].mpicxx)
+        env.set("MPI_CC", self.spec["mpi"].mpicc)
+        env.set("MPICXX", self.spec["mpi"].mpicxx)


same as above.

Sinan81 · 2026-02-25T05:05:12Z

Happy to see that the developers of ALPS are now maintaining the spack package file. Also, it's nice that boost dependency is simplified.

Sinan81

Looks good. approving.

Ooolab · 2026-02-27T14:29:00Z

There is a pipeline error: Status: Failed
ml-linux-aarch64-cpu-build

Is this preventing the merging? No sure what caused this. Any suggestions? Thanks!

Sinan81 · 2026-02-27T19:02:00Z

There is a pipeline error: Status: Failed ml-linux-aarch64-cpu-build

Is this preventing the merging? No sure what caused this. Any suggestions? Thanks!

it must be an unrelated bug. Should not prevent the merge.

Sinan81 · 2026-02-27T19:05:36Z

I don't have permissions to merge. So, we're waiting for one of core spack developers to merge this.

Sinan81 · 2026-02-27T19:07:36Z

repos/spack_repo/builtin/packages/alps/package.py

-        "boost@:1.87 +chrono +date_time +filesystem +iostreams +mpi +numpy"
-        "+program_options +python +regex +serialization +system +test +thread +timer"
-    )
+    depends_on("boost@1.80:")  # Just for headers. Note that the checksums are listed below


if boost is only needed for headers, then probably we should make this a build only dependency like

depends_on("boost@1.80:", type="build")

default dependency is build & link.
This can be improved later.

Sinan81 · 2026-02-27T19:12:08Z

pinging @alalazo for help with merge since he reviewed the previous alps MR.

Ooolab added 2 commits February 1, 2026 00:36

Update ALPS package to version 2.3.4

9409549

Modify ALPS package versions and dependencies

6d4d08e

Updated versions and URLs for ALPS package. Added support for newer Boost versions.

spackbot-triage bot added new-version dependencies update-package labels Feb 24, 2026

spackbot-triage bot requested a review from Sinan81 February 24, 2026 06:52

alecbcs changed the title ~~Update ALPS Version~~ alps: add v2.3.4, modify maintainers & license Feb 24, 2026

Ooolab added 3 commits February 24, 2026 21:01

update alps version

1bcb17c

update alps version

Style Change for package.py for ALPS package

709232f

Style changes for ALPS package

7e52aa6

spackbot-triage bot added the extends label Feb 25, 2026

Clean up package.py by removing blank lines

3f26be1

Removed unnecessary blank lines in package.py.

spackbot-triage bot removed the extends label Feb 25, 2026

Sinan81 reviewed Feb 25, 2026

View reviewed changes

Add MPI support and update maintainers for ALPS

12c2e29

spackbot-triage bot added the new-variant label Feb 26, 2026

spackbot-triage bot requested a review from Sinan81 February 26, 2026 05:03

Ooolab added 2 commits February 26, 2026 00:09

Correct Format for Alps package

2dd1ea8

Format version and variant declarations in package.py

20b7f09

Sinan81 approved these changes Feb 26, 2026

View reviewed changes

rerun CI for ALPS package.py

2a55877

spackbot-triage bot requested a review from Sinan81 February 27, 2026 17:16

Sinan81 approved these changes Feb 27, 2026

View reviewed changes

Sinan81 reviewed Feb 27, 2026

View reviewed changes

Sinan81 requested a review from alalazo February 27, 2026 19:12

Sinan81 approved these changes Feb 27, 2026

View reviewed changes

Conversation

Ooolab commented Feb 24, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sinan81 commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sinan81 left a comment

Choose a reason for hiding this comment

Uh oh!

Ooolab commented Feb 27, 2026

Uh oh!

Sinan81 commented Feb 27, 2026

Uh oh!

Sinan81 commented Feb 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sinan81 commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sinan81 commented Feb 25, 2026 •

edited

Loading