Skip to content

Add feature / balance request triaging for Github Issues #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SlamBamActionman merged 2 commits into from
Jan 7, 2026
Merged

Add feature / balance request triaging for Github Issues #576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c164a
Update triage-procedure.md
SlamBamActionman Jan 1, 2026
a7b4a71
Apply suggestions from code review
SlamBamActionman Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/en/wizden-staff/maintainer/triage-procedure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,24 @@ Non-Maintainer Triagers **must not** tag a PR as `S: Derelict`. This tag is to b

### Closing Issues

Any Triager **may** close Issues if they are no-longer relevant.
#### Bug Reports

Any triager **may** close bug report Issues if they are no longer relevant.

When closing an issue, triage best practice involves adding a comment that contains one or more of the following:
* a link to the PR that resolved it,
* an in-game screenshot or video showing the issue is no longer relevant,
* an in-game screenshot or video showing the issue is no longer relevant (if applicable),
* a note why the issue should not be addressed due to being an intended mechanic (in this last case, mark the Issue with `Issue: Intended Feature`).

#### Feature / Balance Requests

GitHub Issues is not intended to be an idea-guys forum. Any triager **should** close feature/balance request issues that do not cite conceptual approval from a maintainer. It is fine if the approval is included in the issue description; the maintainer doesn't need to comment on the issue itself. If an issue cites approval, triagers **should** tag the issue with the `S: Conceptual Approval` label.

This applies to feature/balance requests created by maintainers, which **must** have conceptual approval from another maintainer. If a maintainer-made request lacks approval, please request it before closing the issue.

### Never Closing PRs

Non-Maintainer Triagers **must never** close Pull Requests. This is **always** a Maintainer responsibility.
Non-maintainer triagers **must never** close pull requests. This is **always** a maintainer's responsibility.

## Other SS14 Github Label Categories

Expand All @@ -108,10 +116,10 @@ Some labels **should not** be used/removed by non-Maintainer Triagers, as they a
| All Size tags | Applied automatically.* |
| S: Approved | Only Maintainers can approve items. Applied automatically. |
| S: Awaiting Changes | Applied automatically. |
| S: Conceptual Approval | Can only be applied by a Maintainer, following Review Procedure. |
| S: Undergoing Maintainer Discussion | Maintainer Discussions are at Maintainers' discretion. |
| S: Conceptual Approval | Can only be applied by a maintainer on PRs, following Review Procedure. Exception for [Issues](#feature--balance-requests). |
| S: Undergoing Maintainer Discussion | Maintainer Discussions are at the maintainers' discretion. |
| S: Art Approval | Can only be applied by an Art Lead following their approval. If the Art Lead has forgotten to apply it, Triagers may apply this label. |
| S: Concern | Only applied by a Maintainer with concern about a particular PR. |
| S: Concern | Only applied by a maintainer with concern about a particular PR. |
| S: DO NOT MERGE | Only applied by a Maintainer to PRs when that must be blocked from merging due to integration problems, extreme controversy, or other good reasons. |

\* May still be applied in certain cases, if the automatic labelling is not working/not implemented.
Loading