Skip to content

clarify review procedure #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slarticodefast wants to merge 1 commit into
base: master
Choose a base branch
from
Open

clarify review procedure #568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/en/wizden-staff/maintainer/review-procedure.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ This document outlines the Maintainer procedure for reviewing and merging PRs to

Pull requests targeting the `staging` or `stable` branch are subject to the [Hotfix Procedure](hotfix-procedure.md).

Any portion of this procedure may be waived and/or modified with written permission (_via Discord or GitHub_) from a Lead Maintainer, Project Manager or Wizard.
Any portion of this procedure may be waived for single PRs with written permission (_via Discord or GitHub_) from a Lead Maintainer, Project Manager or Wizard.

```admonish note
Note that these procedures are ultimately flexible; however, Maintainers who deviate from this policy are expected to provide concrete and valid reasoning when doing so.
Expand Down Expand Up @@ -179,4 +179,4 @@ Major game features usually follow the below dynamic:
2. Maintainers discuss the document in an informal discussion. If most agree, the document is marked with `S: Doc Approved`, and the contributor can start work on the actual feature. As the feature is developed, the document is updated if necessary.
3. Once the content-side implementation is ready to be merged, both the design document and the content pull request are merged in tandem.

The intention behind this is to ensure that contributors do not waste time implementing a feature that may not fit well into Upstream's intended gameplay.
The intention behind this is to ensure that contributors do not waste time implementing a feature that may not fit well into Upstream's intended gameplay.
Loading