Fix Layer constructor in SpriteComponent not properly copying unshaded sprite layers #6368
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constructor creates a new Layer by copying the contents of another Layer. This is used in SpriteSystem.CopySprite() to copy the contents of one sprite to another. Currently, the constructor checks if the source's Shader is null, and if it isn't it copies the source's Shader, UnShaded, and ShaderPrototype variables. However, since Shader is meant to be null whenever a layer is unshaded, it doesn't properly copy over the necessary information for rendering unshaded layers. This moves the UnShaded and ShaderPrototype variable setting out of the Shader null check.
Resolves space-wizards/space-station-14#41948
Before fix:
After fix: