-
Notifications
You must be signed in to change notification settings - Fork 566
Add subscription to cvars change by client #6287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alwayswannahunt
wants to merge
11
commits into
space-wizards:master
Choose a base branch
from
Alwayswannahunt:server-subscription-to-clietn-cvar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add subscription to cvars change by client #6287
Alwayswannahunt
wants to merge
11
commits into
space-wizards:master
from
Alwayswannahunt:server-subscription-to-clietn-cvar
+535
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
PJB3005
requested changes
Nov 30, 2025
Alwayswannahunt
commented
Dec 22, 2025
| return; | ||
| } | ||
|
|
||
| UnsubValueChanged<T>(name, (T newValue, in CVarChangeInfo info) => onChanged(localSession, newValue, in info)); |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk if this will work. I'll write down in this thread after testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds subscription with same structure as
OnValueChangedon same build (server -> sever or client -> client) but for client -> server. Also adds smooth implementation for shared code.Highly inspired by
IConfigurationManagercode, so I cant be sure about doing things right.Why
Some interaction prediction needs it for better UX. Also this goes as "event" way of getting client cvar without every time calling
GetClientCVar. Usage example:2025-11-03.194537.mp4
TODOs