-
Notifications
You must be signed in to change notification settings - Fork 567
tile space edges rendering #6281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
idk how to connect PR to content PR, for unit test fixing |
|
you forgot to implement the interface for |
|
|
the test failed becouse of the ContentTileDefinition.cs doesnt implement the
|
nvm theres a sepreate pr for content that is needed |
Please do not come into this repo with comments like this if you have no idea how engine development usually works. |
| /// <summary> | ||
| /// Possible sprites to use if we're neighboring empty tile. | ||
| /// </summary> | ||
| Dictionary<Direction, ResPath> EdgeSpaceSprites { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this have a default implementation so there's no backwards-compat break, please.
requires: space-wizards/space-station-14#41216
A new field has been added to ITileDefinition:

EdgeSpaceSpritesIf a tile touches space, it will use different edge sprites than when it touches other tiles.
Why is this necessary?
When developing the z-level system, using regular edgesprites at the boundary with air is not aesthetically pleasing. It would be desirable to have the ability to render a separate view of the tile edges in this situation.