Skip to content

Conversation

@TheShuEd
Copy link
Member

@TheShuEd TheShuEd commented Oct 31, 2025

requires: space-wizards/space-station-14#41216

A new field has been added to ITileDefinition: EdgeSpaceSprites
image

If a tile touches space, it will use different edge sprites than when it touches other tiles.

Why is this necessary?

When developing the z-level system, using regular edgesprites at the boundary with air is not aesthetically pleasing. It would be desirable to have the ability to render a separate view of the tile edges in this situation.

image image

@TheShuEd
Copy link
Member Author

idk how to connect PR to content PR, for unit test fixing

@kin98
Copy link

kin98 commented Nov 13, 2025

you forgot to implement the interface for public Dictionary<Direction, ResPath> EdgeSpaceSprites in ContentTileDefinition.cs

@TheShuEd
Copy link
Member Author

you forgot to implement the interface for public Dictionary<Direction, ResPath> EdgeSpaceSprites in ContentTileDefinition.cs

space-wizards/space-station-14#41216

@kin98
Copy link

kin98 commented Nov 13, 2025

the test failed becouse of the ContentTileDefinition.cs doesnt implement the

public interface ITileDefinition : IPrototype

@kin98
Copy link

kin98 commented Nov 13, 2025

the test failed becouse of the ContentTileDefinition.cs doesnt implement the

public interface ITileDefinition : IPrototype

nvm theres a sepreate pr for content that is needed

@PJB3005
Copy link
Member

PJB3005 commented Nov 13, 2025

you forgot to implement the interface for public Dictionary<Direction, ResPath> EdgeSpaceSprites in ContentTileDefinition.cs

Please do not come into this repo with comments like this if you have no idea how engine development usually works.

Comment on lines +33 to +36
/// <summary>
/// Possible sprites to use if we're neighboring empty tile.
/// </summary>
Dictionary<Direction, ResPath> EdgeSpaceSprites { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this have a default implementation so there's no backwards-compat break, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants