-
-
Notifications
You must be signed in to change notification settings - Fork 119
fix: Add SQL Server 2025 support #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add SQL Server 2025 support #227
Conversation
edb3558 to
37539f9
Compare
|
I wanted to add tests, but it looks like the current kitchen tests are not used? They point to a recipe that does not exist (anymore). It looks like at the moment only the 'default' suit is used and works. |
37539f9 to
25576b8
Compare
This adds support for SQL Server 2025.
25576b8 to
e2d1628
Compare
|
interested in this as well. |
Likewise. Looking to start using this soon. |
|
Also interested in this. |
|
thanks for putting this together, looking forward to getting this pulled in |
|
@damacus , do you know of anyone who can review or assist with this pr? I’m looking any people who seem to recently worked on souls-chef cookbooks, and I noticed you seem pretty active. I’ve tried to get access to the chef community slack, but so far just radio silence. Is anything needed for this pr to get a review? |
|
Will do 👍 |
|
Many thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for SQL Server 2025 to the cookbook by updating configuration templates, installation resources, helper libraries, and documentation to recognize and handle the new version.
Changes:
- Adds SQL Server 2025 version string mappings and installation metadata (registry keys, URLs, checksums)
- Implements special handling for SQL Server 2025 license acceptance via command-line parameter
- Updates version exclusion logic for X86 and instant file initialization features to include 2025
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/ConfigurationFile.ini.erb | Excludes SQL Server 2025 from X86 installation option and includes it in instant file initialization support |
| resources/install.rb | Adds command-line license acceptance parameter specifically for SQL Server 2025 installations |
| libraries/helper.rb | Adds SQL Server 2025 mappings for registry version strings, installation directory versions, download URLs, package names, and checksums |
| documentation/sql_server_configure.md | Updates documentation to list 2025 as a valid version option |
| README.md | Adds Microsoft SQL Server 2025 to the list of supported versions |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
damacus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of syntax nicities.
|
I'll add tests to the existing setup before I merge this if they're not there already |
|
Thank you @damacus |
This adds support for SQL Server 2025.
Description
Adds SQL Server 2025 Support
Issues Resolved
#226
Check List
fix: resolve bug in resource,feat: add new property,docs: update READMEDO NOT manually edit these files:
metadata.rbversion - Managed by release-pleaseCHANGELOG.md- Auto-generated from conventional commitsThe release process:
Need help? See Conventional Commits guide