Skip to content

Conversation

@Danyyer
Copy link
Contributor

@Danyyer Danyyer commented Jan 9, 2026

This adds support for SQL Server 2025.

Description

Adds SQL Server 2025 Support

Issues Resolved

#226

Check List

  • All commit messages follow Conventional Commits format
    • Required: This triggers our automated CHANGELOG and release pipeline (release-please)
    • Without conventional commits, your changes cannot be released
    • Examples: fix: resolve bug in resource, feat: add new property, docs: update README
  • New functionality includes testing
  • New functionality has been documented in the README if applicable

⚠️ Important: Automated Release Workflow

DO NOT manually edit these files:

  • metadata.rb version - Managed by release-please
  • CHANGELOG.md - Auto-generated from conventional commits
  • ❌ Version tags - Created automatically on release

The release process:

  1. Merge PR with conventional commits → release-please creates a release PR
  2. Merge release PR → automatic version bump, CHANGELOG update, and Supermarket publish
  3. Your changes are released! 🎉

Need help? See Conventional Commits guide

@Danyyer Danyyer requested a review from a team as a code owner January 9, 2026 16:56
@Danyyer Danyyer force-pushed the add_support_for_sql_server_2025 branch 3 times, most recently from edb3558 to 37539f9 Compare January 9, 2026 17:08
@Danyyer
Copy link
Contributor Author

Danyyer commented Jan 9, 2026

I wanted to add tests, but it looks like the current kitchen tests are not used? They point to a recipe that does not exist (anymore).

It looks like at the moment only the 'default' suit is used and works.
Should I add a test for 2025?

@Danyyer Danyyer force-pushed the add_support_for_sql_server_2025 branch from 37539f9 to 25576b8 Compare January 9, 2026 17:17
This adds support for SQL Server 2025.
@Danyyer Danyyer force-pushed the add_support_for_sql_server_2025 branch from 25576b8 to e2d1628 Compare January 9, 2026 17:37
@bryanwieg
Copy link

interested in this as well.

@aspec451
Copy link

interested in this as well.

Likewise. Looking to start using this soon.

@sqlslinger
Copy link

Also interested in this.

@aae42
Copy link

aae42 commented Jan 13, 2026

thanks for putting this together, looking forward to getting this pulled in

@bryanwieg
Copy link

@damacus , do you know of anyone who can review or assist with this pr?

I’m looking any people who seem to recently worked on souls-chef cookbooks, and I noticed you seem pretty active. I’ve tried to get access to the chef community slack, but so far just radio silence.

Is anything needed for this pr to get a review?

@damacus
Copy link
Member

damacus commented Jan 13, 2026

Will do 👍
Unless someone else get to it tomorrow.
In the mean time I'll set copilot on it

@bryanwieg
Copy link

Many thanks :)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for SQL Server 2025 to the cookbook by updating configuration templates, installation resources, helper libraries, and documentation to recognize and handle the new version.

Changes:

  • Adds SQL Server 2025 version string mappings and installation metadata (registry keys, URLs, checksums)
  • Implements special handling for SQL Server 2025 license acceptance via command-line parameter
  • Updates version exclusion logic for X86 and instant file initialization features to include 2025

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
templates/ConfigurationFile.ini.erb Excludes SQL Server 2025 from X86 installation option and includes it in instant file initialization support
resources/install.rb Adds command-line license acceptance parameter specifically for SQL Server 2025 installations
libraries/helper.rb Adds SQL Server 2025 mappings for registry version strings, installation directory versions, download URLs, package names, and checksums
documentation/sql_server_configure.md Updates documentation to list 2025 as a valid version option
README.md Adds Microsoft SQL Server 2025 to the list of supported versions

damacus and others added 2 commits January 13, 2026 18:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@damacus damacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of syntax nicities.

@damacus
Copy link
Member

damacus commented Jan 13, 2026

I'll add tests to the existing setup before I merge this if they're not there already

@damacus damacus self-requested a review January 14, 2026 09:52
@damacus damacus changed the title Add SQL Server 2025 support fix: Add SQL Server 2025 support Jan 14, 2026
@damacus damacus merged commit 19ac362 into sous-chefs:main Jan 14, 2026
6 of 7 checks passed
@damacus damacus mentioned this pull request Jan 14, 2026
@bryanwieg
Copy link

Thank you @damacus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants