Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 11, 2025

  • Add RPATH support for custom OpenSSL libraries
  • Add comprehensive unit tests for RPATH functionality
  • Fix RSpec test stub to ensure bash resource runs during testing
  • Resolve merge conflicts with main branch (PCRE2 support)
  • Verify all unit tests pass (29 tests)
  • Ensure code passes cookstyle linting

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Copilot AI changed the title [WIP] OpenSSL doesn't compile correctly in the OpenSSL test suite Fix OpenSSL compilation on RHEL derivatives by adding RPATH support Sep 11, 2025
Copilot AI requested a review from damacus September 11, 2025 23:16
@damacus damacus changed the title Fix OpenSSL compilation on RHEL derivatives by adding RPATH support fix: OpenSSL compilation on RHEL derivatives by adding RPATH support Sep 15, 2025
@damacus damacus marked this pull request as ready for review September 15, 2025 07:44
@damacus damacus requested a review from a team as a code owner September 15, 2025 07:44
@damacus
Copy link
Member

damacus commented Oct 16, 2025

@copilot fix these rspec errors!

Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 16, 2025

@copilot fix these rspec errors!

Fixed! The RSpec test was stubbing the command to return a truthy value, which caused the bash resource's not_if guard to prevent execution. Changed the stub to return false so the resource runs and can be tested properly. All tests now pass. (commit: 80e5a)

@damacus damacus changed the title fix: OpenSSL compilation on RHEL derivatives by adding RPATH support fix(install): OpenSSL compilation on RHEL derivatives by adding RPATH support Oct 20, 2025
@damacus damacus changed the title fix(install): OpenSSL compilation on RHEL derivatives by adding RPATH support fix(Install): OpenSSL compilation on RHEL derivatives by adding RPATH support Oct 20, 2025
@github-actions
Copy link

Slowest examples

Top 10 slowest examples (1.08 seconds, 65.34% of total time)
Example Description Time in seconds
spec/unit/recipes/cache_spec.rb:45 haproxy_cache create a cache, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.14558
spec/unit/recipes/global_spec.rb:26 haproxy_config_global create haproxy config global is expected to render file "/etc/haproxy/haproxy.cfg" 0.13581
spec/unit/recipes/install_spec.rb:12 haproxy_install install haproxy using the package method is expected to install package "haproxy" 0.1334
spec/unit/recipes/fastcgi_spec.rb:63 haproxy_fastcgi create a fastcgi resource, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.11855
spec/unit/recipes/listen_spec.rb:105 haproxy_listen extra options http-request rule should be placed before use_backend rule is expected to render file "/etc/haproxy/haproxy.cfg" 0.09913
spec/unit/recipes/peer_spec.rb:45 haproxy_peer create a peers section, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.09662
spec/unit/recipes/listen_spec.rb:39 haproxy_listen create template with a listen resource is expected to render file "/etc/haproxy/haproxy.cfg" 0.09612
spec/unit/recipes/defaults_spec.rb:26 haproxy_config_defaults create a cache, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.09086
spec/unit/recipes/frontend_backend_spec.rb:33 haproxy_frontend create frontend and backend with http-request rule placed before use_backend is expected to render file "/etc/haproxy/haproxy.cfg" 0.084
spec/unit/recipes/listen_spec.rb:106 haproxy_listen extra options http-request rule should be placed before use_backend rule is expected not to render file "/etc/haproxy/haproxy.cfg" with content /use_backend admin0 if path_beg /admin0.*http-request add-header Test Value/m 0.0839

ramereth
ramereth previously approved these changes Oct 22, 2025
@damacus damacus enabled auto-merge (squash) October 31, 2025 08:26
@damacus
Copy link
Member

damacus commented Oct 31, 2025

@copilot Fix the merge conflicts

Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
auto-merge was automatically disabled October 31, 2025 08:34

Head branch was pushed to by a user without write access

Copy link
Contributor Author

Copilot AI commented Oct 31, 2025

@copilot Fix the merge conflicts

Merge conflicts resolved! The conflict was in spec/unit/recipes/install_spec.rb where the new PCRE2 platform tests from main conflicted with our custom OpenSSL tests. I merged both sets of tests, and all 29 unit tests now pass. (commit: ce1837e)

Copilot AI requested a review from damacus October 31, 2025 08:35
@damacus
Copy link
Member

damacus commented Nov 7, 2025

@copilot check mergability.

@damacus damacus enabled auto-merge (squash) November 7, 2025 02:57
@damacus damacus disabled auto-merge November 7, 2025 02:57
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Slowest examples

Top 10 slowest examples (1.21 seconds, 47.59% of total time)
Example Description Time in seconds
spec/unit/recipes/install_spec.rb:58 haproxy_install compile HAProxy on AlmaLinux 10 (uses PCRE2) is expected to install package "["pcre2-devel", "openssl-devel", "zlib-devel", "systemd-devel", "tar"]" 0.19876
spec/unit/recipes/global_spec.rb:26 haproxy_config_global create haproxy config global is expected to render file "/etc/haproxy/haproxy.cfg" 0.1657
spec/unit/recipes/cache_spec.rb:45 haproxy_cache create a cache, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.15057
spec/unit/recipes/fastcgi_spec.rb:63 haproxy_fastcgi create a fastcgi resource, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.12759
spec/unit/recipes/listen_spec.rb:61 haproxy_listen option parameter with array of options is expected to render file "/etc/haproxy/haproxy.cfg" 0.10652
spec/unit/recipes/peer_spec.rb:45 haproxy_peer create a peers section, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.10109
spec/unit/recipes/listen_spec.rb:106 haproxy_listen extra options http-request rule should be placed before use_backend rule is expected not to render file "/etc/haproxy/haproxy.cfg" with content /use_backend admin0 if path_beg /admin0.*http-request add-header Test Value/m 0.10029
spec/unit/recipes/defaults_spec.rb:26 haproxy_config_defaults create a cache, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.09151
spec/unit/recipes/frontend_backend_spec.rb:34 haproxy_frontend create frontend and backend with http-request rule placed before use_backend is expected not to render file "/etc/haproxy/haproxy.cfg" with content /use_backend admin0 if path_beg /admin0.*http-request add-header Test Value/m 0.08763
spec/unit/recipes/mailer_spec.rb:48 haproxy_mailer create a mailer, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.08756

@damacus damacus merged commit c84c8e3 into main Nov 7, 2025
7 checks passed
@damacus damacus deleted the copilot/fix-503 branch November 7, 2025 02:58
Copilot AI requested a review from damacus November 7, 2025 02:58
Copilot AI added a commit that referenced this pull request Nov 7, 2025
… support (#551)

*  Add RPATH support for custom OpenSSL libraries to fix RHEL linking issue

Co-authored-by: damacus <40786+damacus@users.noreply.github.com>

* fix: Correct stub_command in RSpec test to allow bash resource execution

Co-authored-by: damacus <40786+damacus@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: damacus <40786+damacus@users.noreply.github.com>
Co-authored-by: Dan Webb <dan.webb@damacus.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants