Skip to content

Conversation

@damacus
Copy link
Member

@damacus damacus commented Jan 14, 2026

Summary

This PR fixes the failing test suites identified in #815 and its sub-issues by addressing the root causes of each failure.

Changes

1. Amazon Linux 2023 mod-wsgi (#816)

  • Added amazon platform family to apache_mod_wsgi_package helper
  • Added amazon platform family to apache_mod_wsgi_filename helper
  • Amazon Linux 2023 now correctly uses python3-mod_wsgi package and mod_wsgi_python3.so filename

2. OpenSUSE Leap 15 mod-auth-cas (#817)

  • Updated apache_mod_auth_cas_devel_packages to use PCRE2 instead of PCRE1
  • mod_auth_cas v1.2 requires libpcre2-8 for building from source
  • Updated packages for all platforms: pcre-develpcre2-devel, libpcre++-devlibpcre2-dev

3. Ubuntu 24.04 PHP (#818)

  • Configuration was already correct (libphp8.3.so)
  • Re-enabled in CI to verify

4. Debian 13 PHP

  • Added specific handling for Debian 13 with PHP 8.4 (libphp8.4.so)
  • Previously Debian 13 was incorrectly using the Debian 12 filename

5. OpenSUSE Leap 15 wsgi (#819)

  • Configuration was already correct
  • Re-enabled in CI to verify

Testing

  • All 298 unit tests pass
  • Added new spec/libraries/mod_php_spec.rb test file for PHP helper coverage
  • Updated existing tests in mod_wsgi_spec.rb and mod_auth_cas_spec.rb

CI Changes

Removed all exclusions from the CI workflow matrix:

  • amazonlinux-2023 / mod-wsgi
  • ubuntu-2404 / php
  • opensuse-leap-15 / mod-auth-cas
  • opensuse-leap-15 / wsgi
  • opensuse-leap-15 / mod-wsgi
  • debian-13 / php

Fixes #815, #816, #817, #818, #819

- Add amazon platform family to apache_mod_wsgi_package and apache_mod_wsgi_filename helpers
- Update mod_auth_cas devel packages from pcre to pcre2 for v1.2 compatibility
- Add Debian 13 PHP 8.4 filename support (libphp8.4.so)
- Add mod_php_spec.rb tests for PHP helper functions
- Update mod_wsgi_spec.rb and mod_auth_cas_spec.rb tests
- Remove CI exclusions for amazonlinux-2023/mod-wsgi, ubuntu-2404/php,
  opensuse-leap-15/mod-auth-cas, opensuse-leap-15/mod-wsgi, debian-13/php

Fixes #815, #816, #817, #818, #819
@damacus damacus requested a review from a team as a code owner January 14, 2026 12:38
@github-actions
Copy link

Slowest examples

Top 10 slowest examples (3.19 seconds, 16.2% of total time)
Example Description Time in seconds
spec/resources/mod_php_spec.rb:25 apache2_mod_php Setup and enable PHP module is expected to install package "libapache2-mod-php" 0.4581
spec/resources/mod_spec.rb:261 apache2_install mod_cache_disk outputs template correctly 0.4145
spec/libraries/pid_file_spec.rb:25 #apache_pid_file with SUSE family is expected to write log "/var/run/httpd2.pid" 0.37174
spec/resources/conf_spec.rb:41 apache2_install install an apache2_module with default properties Creates the charset template 0.37133
spec/resources/conf_spec.rb:34 apache2_install install an apache2_module with default properties Creates the ports template 0.3085
spec/libraries/log_spec.rb:61 #default_access_log with amazon family is expected to write log "access.log" 0.30731
spec/resources/mod_spec.rb:274 apache2_install mod_autoindex outputs template correctly 0.26084
spec/libraries/devel_package_spec.rb:26 #apache_devel_package suse is expected to write log "apache2-devel" 0.25294
spec/resources/default_site_spec.rb:20 apache2_install Enable the default site Creates the default site template 0.22308
spec/resources/mod_auth_cas_spec.rb:55 apache2_mod_auth_cas ubuntu is expected to render file "/etc/apache2/mods-available/auth_cas.conf" 0.22186

@damacus damacus closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failing suites

2 participants