Conversation
…ually instead of through scripts)
TheRedDaemon
requested changes
Jan 15, 2026
README.md
Outdated
| ```bat | ||
| .\cmakew -P create-include-lists.cmake | ||
| ``` | ||
| Should any files be added to the source code in `src/core` or the ucp files in `ucp`, the file lists in `cmake/` should be updated accordingly. |
Contributor
There was a problem hiding this comment.
I think the "in src/core" could be removed from the first sentence and instead the sentence could be followed by a bullet list with the four list files and what they should contain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, the intention of the file list .txt files should be clear and only one method should be present to generate them.