Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 11 11
Lines 595 596 +1
=======================================
+ Hits 589 590 +1
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_690ccd29b56c83279634e7e3a10e3e0a
Note
Adds comprehensive tests for walk/permission/error scenarios and scanner failures, plus a minor refactor to handle scanner errors via a local variable.
internal/fn/scanner_test.go:filepath.Walk(including concurrent deletion).bufio.Scannerfailure and returnnil.internal/fn/scanner_internal_test.go:ReadSingleConfigreturnsnilon scanner errors.internal/fn/scanner.go: Storescanner.Err()in localscanErrbefore returning, clarifying error handling inReadSingleConfig.Written by Cursor Bugbot for commit 73db837. This will update automatically on new commits. Configure here.