Conversation
soorajshankar
left a comment
There was a problem hiding this comment.
Thank you for submitting the pull request! The new features look promising. However, I’d like to ensure that the tool remains generic enough to handle any type of loglines.
Please verify that this change works correctly with the command node test/simulate.js | node index.js. Some logs from there don’t render correctly with the current modifications. Also, don’t forget to add it to the package.json if it’s missing. Feel free to add additional test cases as needed.
To expedite the process, let’s break this down into individual pull requests:
- Color change based on the logline prefix
- Filters based on Prefix (this might be tricky to generalize)
- Time filter
Thank you for your contribution! 🙌
|
Hey, so it works well with the given example, but parsing the logs with a regex check may introduce new set of bugs when people run this against wide variety of loglines. I like the filtering and showing logs in different colors, but I don't think we should enforce the parsing logic as a default parsing logic. I'll make some tweaks over next weekend on the parsing configuration, and then may be this PR can utilise the output from that to do filtering and colouring. thoughts? |
Sounds good to me. |
More ChatGPT...