Add icons for open and private group permissions #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
In its current state this PR only adds SVG files under images/ directory. A circle and a pacman. They are of slightly different nominal sizes as I got them from wikimedia and tweaked from there, I'm not sure it matters (I'm not expert, but being vector it shouldn't?). The icons are not used by the program source code. I'm thinking we may want another icon being a closed circle with a key inside, meaning the group is password-protected in addition to being just private. Does it make sense ? Would it also be possible to have a public room protected by a password ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References GH-171