chore(typescript): upgrade node to 24 and enable typescript go experimental#236
Merged
chore(typescript): upgrade node to 24 and enable typescript go experimental#236
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to upgrade Node.js from version 22 to version 24 and adopts the experimental TypeScript native compiler (tsgo). The changes update the Node.js version across multiple configuration files and replace the standard TypeScript compiler with the @typescript/native-preview package. Additionally, the start script is updated to use tsx's native --env-file flag instead of the env-cmd package.
Key Changes:
- Upgrade Node.js from version 22 to 24 across all configuration files
- Replace the build command from "tsc" to "tsgo" (experimental TypeScript native compiler)
- Switch from env-cmd to tsx's native --env-file flag for environment variable loading
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Node.js-related scripts, adds @typescript/native-preview, removes env-cmd, changes TypeScript version to 5.9.3, switches build command to tsgo |
| package-lock.json | Adds @typescript/native-preview and platform-specific packages, removes env-cmd, marks several packages as peer dependencies |
| Dockerfile | Updates base images from node:22 to node:24 for both build and runtime stages |
| .nvmrc | Changes Node.js version from v22 to v24 |
| .vscode/settings.json | Adds experimental tsgo setting for VS Code |
| .github/.devcontainer/devcontainer.json | Updates devcontainer image to use Node.js 24 |
| .devcontainer/devcontainer.json | Adds TypeScript native-preview VS Code extension |
Critical Issues Found:
- Node.js version 24 does not exist yet (scheduled for April 2026)
- Multiple packages incorrectly marked as peer dependencies in package-lock.json
- TypeScript version appears to be downgraded from 5.8.2 to 5.9.3
- Missing documentation about the experimental tsgo adoption
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.