feat(devcontainer): prebuilds devcontainer image#216
Conversation
1d71ae5 to
c54ee13
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a CI/CD workflow to prebuild devcontainer images, improving developer onboarding speed by publishing prebuilt images to GitHub Container Registry instead of building features on each container creation.
Key Changes:
- Added GitHub Actions workflow to automatically build and push devcontainer images on changes
- Created build configuration at
.github/.devcontainer/devcontainer.jsonwith all required features - Updated
.devcontainer/devcontainer.jsonto reference the prebuilt image
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.github/workflows/devcontainer.yaml |
Implements CI/CD pipeline to build and publish devcontainer images to GHCR with version tagging |
.github/.devcontainer/devcontainer.json |
Defines the build-time configuration including base image, features, and VS Code extensions |
.devcontainer/devcontainer.json |
Updated to use the prebuilt image instead of building features locally |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/devcontainer.yaml
Outdated
| - '.devcontainer/**' | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| paths: | ||
| - '.devcontainer/**' |
There was a problem hiding this comment.
The workflow only triggers on changes to .devcontainer/**, but the build configuration file is located at .github/.devcontainer/devcontainer.json. Changes to the build configuration won't trigger the workflow.
Add .github/.devcontainer/** to the paths:
paths:
- '.devcontainer/**'
- '.github/.devcontainer/**'| - '.devcontainer/**' | |
| branches: | |
| - main | |
| pull_request: | |
| paths: | |
| - '.devcontainer/**' | |
| - '.devcontainer/**' | |
| - '.github/.devcontainer/**' | |
| branches: | |
| - main | |
| pull_request: | |
| paths: | |
| - '.devcontainer/**' | |
| - '.github/.devcontainer/**' |
c54ee13 to
a7b2ee3
Compare
a7b2ee3 to
39c2707
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "appPort": [ | ||
| "27100:27100/udp", | ||
| "27101:27101/udp" | ||
| ] |
There was a problem hiding this comment.
Missing comma after the appPort array. This will cause a JSON syntax error when the devcontainer configuration is parsed. Add a comma after the closing bracket on line 30.
| ] | |
| ], |
No description provided.