Skip to content

Comments

feat(devcontainer): prebuilds devcontainer image#216

Merged
sonikro merged 1 commit intomainfrom
devcontainer-workflow
Nov 19, 2025
Merged

feat(devcontainer): prebuilds devcontainer image#216
sonikro merged 1 commit intomainfrom
devcontainer-workflow

Conversation

@sonikro
Copy link
Owner

@sonikro sonikro commented Nov 19, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 19, 2025 01:58
@sonikro sonikro force-pushed the devcontainer-workflow branch 2 times, most recently from 1d71ae5 to c54ee13 Compare November 19, 2025 02:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a CI/CD workflow to prebuild devcontainer images, improving developer onboarding speed by publishing prebuilt images to GitHub Container Registry instead of building features on each container creation.

Key Changes:

  • Added GitHub Actions workflow to automatically build and push devcontainer images on changes
  • Created build configuration at .github/.devcontainer/devcontainer.json with all required features
  • Updated .devcontainer/devcontainer.json to reference the prebuilt image

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
.github/workflows/devcontainer.yaml Implements CI/CD pipeline to build and publish devcontainer images to GHCR with version tagging
.github/.devcontainer/devcontainer.json Defines the build-time configuration including base image, features, and VS Code extensions
.devcontainer/devcontainer.json Updated to use the prebuilt image instead of building features locally

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 6 to 11
- '.devcontainer/**'
branches:
- main
pull_request:
paths:
- '.devcontainer/**'
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow only triggers on changes to .devcontainer/**, but the build configuration file is located at .github/.devcontainer/devcontainer.json. Changes to the build configuration won't trigger the workflow.

Add .github/.devcontainer/** to the paths:

paths:
  - '.devcontainer/**'
  - '.github/.devcontainer/**'
Suggested change
- '.devcontainer/**'
branches:
- main
pull_request:
paths:
- '.devcontainer/**'
- '.devcontainer/**'
- '.github/.devcontainer/**'
branches:
- main
pull_request:
paths:
- '.devcontainer/**'
- '.github/.devcontainer/**'

Copilot uses AI. Check for mistakes.
@sonikro sonikro force-pushed the devcontainer-workflow branch from c54ee13 to a7b2ee3 Compare November 19, 2025 02:07
Copilot AI review requested due to automatic review settings November 19, 2025 02:08
@sonikro sonikro force-pushed the devcontainer-workflow branch from a7b2ee3 to 39c2707 Compare November 19, 2025 02:08
@sonikro sonikro merged commit e2b6e19 into main Nov 19, 2025
5 of 7 checks passed
@sonikro sonikro deleted the devcontainer-workflow branch November 19, 2025 02:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"appPort": [
"27100:27100/udp",
"27101:27101/udp"
]
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma after the appPort array. This will cause a JSON syntax error when the devcontainer configuration is parsed. Add a comma after the closing bracket on line 30.

Suggested change
]
],

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant