Match indicating failure returns as success

[jameswithers]

The -q flag at

magestack-scripts/cli/magento-2/cron.sh

Line 49 in 509b846

grep -qE "${ERROR_REGEX}" $LOG_FILE

means grep returns 0 if a match is found (http://man7.org/linux/man-pages/man1/grep.1.html).

This appears to then be set as the result at

magestack-scripts/cli/magento-2/cron.sh

Line 50 in 509b846

[ $? -ne 0 ] && RES=$?

when a result of zero is deemed a success (which it isn't in this case, as grep has found matches).

This proposed change better reflects the desired logic here: even if a command e.g. the one at

magestack-scripts/cli/magento-2/cron.sh

Line 44 in 509b846

echo "cd $REL_INSTALLDIR; $PHP_BIN bin/magento cron:run" | timeout $MAX_DURATION fakechroot /usr/sbin/chroot /microcloud/domains/$DOMAIN_GROUP /bin/bash >> $LOG_FILE 2>&1; [ $? -ne 0 ] && RES=$?

successfully exits, it may still have logged an error, and this error (if found via a regex) needs to exit the cron wrapper itself with a value indicating failure (as well as sending an email)