Skip to content

Conversation

@srzeszut
Copy link
Contributor

@srzeszut srzeszut commented Jan 16, 2026

Added copy and fullscreen button and highlighting to stream elements

@srzeszut srzeszut linked an issue Jan 16, 2026 that may be closed by this pull request
@srzeszut srzeszut marked this pull request as ready for review January 19, 2026 08:16
@kraleppa
Copy link
Member

Some UI nitpicks:

  1. Can you make these gaps even?
Screenshot 2026-01-21 at 10 42 07
  1. I think you can move this button here (as you did in case of exceptions
Screenshot 2026-01-21 at 10 45 29 Screenshot 2026-01-21 at 10 44 29

Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🐬 After fixing above issues we can merge

@kraleppa kraleppa requested a review from hhubert6 January 21, 2026 09:53
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from what @kraleppa mentioned LGTM

<.copy_button
id={"#{@dom_id}-copy-button"}
variant="icon-button"
value={inspect(@stream_element)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value={inspect(@stream_element)}
value={TermParser.term_to_copy_string(@stream_element)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streams display improvements

4 participants